Skip to content

Commit

Permalink
Respond to review comments that I'd missed
Browse files Browse the repository at this point in the history
  • Loading branch information
RobertLuptonTheGood committed Jan 29, 2019
1 parent 98ab163 commit 8ecfa87
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions python/lsst/obs/base/yamlCamera.py
Original file line number Diff line number Diff line change
Expand Up @@ -194,31 +194,31 @@ def makeBBoxFromList(ylist):
return afwGeom.BoxI(afwGeom.PointI(x0, y0), afwGeom.ExtentI(xsize, ysize))


def makeTransformDict(nativeSys, transformYamlDict, plateScale):
def makeTransformDict(nativeSys, transformDict, plateScale):
"""Make a dictionary of TransformPoint2ToPoint2s from yaml, mapping from nativeSys
Parameters
----------
nativeSys : `lsst.afw.cameraGeom.CameraSys`
transformYamlDict : `dict`
transformDict : `dict`
A dict specifying parameters of transforms; keys are camera system names.
plateScale : `lsst.geom.Angle`
The size of a pixel in angular units/mm (e.g. 20 arcsec/mm for LSST)
Returns
-------
transforms : `dict`
A dict of lsst.afw.cameraGeom.CameraSys : lsst.afw.geom.TransformPoint2ToPoint2
A dict of `lsst.afw.cameraGeom.CameraSys` : `lsst.afw.geom.TransformPoint2ToPoint2`
The resulting dict's keys are CameraSys,
The resulting dict's keys are `~lsst.afw.cameraGeom.CameraSys`,
and the values are Transforms *from* NativeSys *to* CameraSys
"""
# As other comments note this is required, and this is one function where it's assumed
assert nativeSys == cameraGeom.FOCAL_PLANE, "Cameras with nativeSys != FOCAL_PLANE are not supported."

resMap = dict()

for key, transform in transformYamlDict.items():
for key, transform in transformDict.items():
transformType = transform["transformType"]
knownTransformTypes = ["affine", "radial"]
if transformType not in knownTransformTypes:
Expand Down

0 comments on commit 8ecfa87

Please sign in to comment.