Add crude ERA from LST method and a test for it. tickets/DM-8052 #10
Conversation
| LST = 90*degrees | ||
| Longitude = 50*degrees | ||
| era = self.makeRawVisitInfo.eraFromLstAndLongitude(LST, Longitude) | ||
| self.assertEqual(era, LST-Longitude) |
There was a problem hiding this comment.
I'm uneasy about testing exact equality here, since these are floats. Wouldn't assertAnglesAlmostEqual (or whatever it's called) be safer?
There was a problem hiding this comment.
Good point. It's assertAnglesNearlyEqual now.
| @@ -241,6 +241,15 @@ def popMjdDate(self, md, key, timesys=None): | |||
| return BadDate | |||
|
|
|||
| @staticmethod | |||
| def eraFromLstAndLongitude(lst, longitude): | |||
There was a problem hiding this comment.
Please document your longitude sign convention.
There was a problem hiding this comment.
Also I believe this takes and returns lsst.afw.geom.Angle objects, NOT angles in degrees. Please fix the documentation accordingly. Please consider testing at least one argument to make sure it is an Angle and not a float (since Angle - float is an error, you just need to test one, but you could certainly test both for clarity).
There was a problem hiding this comment.
I've documented longitude and added a test to check that it raises on float-Angle.
parejkoj
force-pushed
the
tickets/DM-8052
branch
from
22e64d4
to
4ae8f78
Compare
No description provided.