DM-8212: Add support for reading metadata, length and schema of a catalog #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
requested changes
Nov 10, 2016
| @@ -207,6 +209,31 @@ def testSubMap(self): | |||
| 'ccd = 13\nheight = 400\nimageOrigin = "PARENT"\n' | |||
| 'llcX = 200\nllcY = 100\nwidth = 300\n') | |||
|
|
|||
| def testCatalogExtras(self): | |||
| butler = dafPersist.ButlerFactory(mapper=self.mapper).create() | |||
There was a problem hiding this comment.
Do you really need to do this via a ButlerFactor? Can't you just create a butler directly?
| del subId['bbox'] | ||
| return mapping.lookup(format, subId) | ||
| setattr(self, "query_" + datasetType + "_sub", querySubClosure) | ||
| def setMethods(suffix, mapImpl=None, bypassImpl=None, queryImpl=None): |
There was a problem hiding this comment.
I feel like this whole subPolicy block that you've cleanedup/added (basically most of the contents of this inner for loop) should be pulled into a separate _addPolicies method. __init__ is really long as it stands, and this could help break it up (I didn't even see that this was all in a double-for loop!).
PaulPrice
force-pushed
the
tickets/DM-8212
branch
from
c83eaee
to
f963d06
Compare
Extra dataset features (e.g., "raw_sub", "raw_md", "raw_filename") are
are created from the original mapping (e.g., "raw") by defining a bunch
of extra methods. This patch replaces the sea of
if not hasattr(self, someName):
setattr(self, someName, someImpl)
calls with a common function to set the implementations for each extra
dataset feature. This clarifies the code and makes it easier to add more
extra features.
Moved the setting of dataset mappings into its own method, as it's
specialised and too much to have in __init__.
Added "foo_md", "foo_len" and "foo_schema" if "foo" is a catalog. Note that the "foo_schema" commonly has a different meaning because it's usually defined explicitly if the "foo" is an important pipeline output.
PaulPrice
force-pushed
the
tickets/DM-8212
branch
from
f963d06
to
d33c0b1
Compare
parejkoj
approved these changes
Nov 14, 2016
|
That's cleaner, thanks. I think it would be great if the guts of the inner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.