Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-14670: Convert fgcmcal output stars to stack reference catalog format #115

Merged
merged 2 commits into from Oct 10, 2018
Merged

DM-14670: Convert fgcmcal output stars to stack reference catalog format #115

merged 2 commits into from Oct 10, 2018

Conversation

erykoff
Copy link
Contributor

@erykoff erykoff commented Oct 10, 2018

Small additions to datasets.yaml

TallJimbo
TallJimbo approved these changes Oct 10, 2018
View reviewed changes
Copy link
Member

@TallJimbo TallJimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You might want to squash them into one commit; I don't think keeping them separate adds much value, and at first I was confused by the "make it a SourceCatalog, no, make it not a SourceCatalog" sequence.

@erykoff erykoff merged commit 5ec05d6 into master Oct 10, 2018
@timj timj deleted the tickets/DM-14670 branch August 17, 2020 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TallJimbo TallJimbo TallJimbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@erykoff @TallJimbo