DM-15514: Write insertFakeObjectsTask to add fake sources for QA purposes #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natelust
approved these changes
Feb 22, 2019
policy/datasets.yaml
Outdated
| @@ -564,6 +564,25 @@ src: | |||
| python: lsst.afw.table.SourceCatalog | |||
| tables: raw | |||
| template: '' | |||
| fakeSourceCat: | |||
| description: "A calexp sized catalog of fake sources" | |||
There was a problem hiding this comment.
What does "calexp sized catalog" mean, is is somehow the size of a calexp? is it a calexp, sized catalog? Put in a more detailed description
policy/datasets.yaml
Outdated
| tables: raw | ||
| template: '' | ||
| deepCoadd_fakeSourceCat: | ||
| description: "A deepCoadd_calexp sized catalog of fake sources" |
policy/exposures.yaml
Outdated
| @@ -5,6 +5,13 @@ deepCoadd: | |||
| python: lsst.afw.image.ExposureF | |||
| template: deepCoadd/%(filter)s/%(tract)d/%(patch)s.fits | |||
| level: Skytile | |||
| fakes_deepCoadd: | |||
| description: "A coadd assembled from direct warps, produced by AssembleCoaddTask, with fakes added." | |||
There was a problem hiding this comment.
fakes => fake objects, breaks degeneracy between fake objects inserted in the warps and having fake warps included in the coadd
policy/exposures.yaml
Outdated
| @@ -28,6 +35,13 @@ deepCoadd_calexp: | |||
| python: lsst.afw.image.ExposureF | |||
| template: deepCoadd-results/%(filter)s/%(tract)d/%(patch)s/calexp-%(filter)s-%(tract)d-%(patch)s.fits | |||
| level: None | |||
| fakes_deepCoadd_calexp: | |||
| description: "Same as deepCoadd_calexp but with fakes" | |||
There was a problem hiding this comment.
see above: fakes => fake objects
sr525
force-pushed
the
tickets/DM-15514
branch
2 times, most recently
from
56db8b8
to
12550ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.