DM-16429: Ensure WCS are retrieved properly when loaded individually #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
changed the title
The full SkyWcs may not be saved in the header, so get the one that ExposureFitsReader reads (it knows which one to pick).
parejkoj
force-pushed
the
tickets/DM-16429
branch
from
7e6396f
to
5060460
Compare
timj
reviewed
Mar 16, 2019
python/lsst/obs/base/cameraMapper.py
Outdated
| fitsReader = afwImage.ExposureFitsReader(location.getLocationsWithRoot()[0]) | ||
| return fitsReader.readVisitInfo() | ||
|
|
||
| setMethods("visitInfo", getVisitInfo) |
There was a problem hiding this comment.
Shouldn't this be bypassImpl=getVisitInfo? Similarly for filter below.
There was a problem hiding this comment.
Good catch, thanks.
parejkoj
force-pushed
the
tickets/DM-16429
branch
from
5060460
to
0947555
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.