DM-13757: enable jointcal config writing #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erykoff
requested changes
Mar 14, 2019
policy/datasets.yaml
Outdated
| @@ -589,6 +589,11 @@ srcMatchFull: | |||
| python: lsst.afw.table.BaseCatalog | |||
| tables: raw | |||
| template: '' | |||
| jointcal_config: | |||
| persistable: Config | |||
| python: lsst.pipe.tasks.processCcd.ProcessCcdConfig | |||
There was a problem hiding this comment.
I believe this should be lsst.jointcal.JointcalConfig
There was a problem hiding this comment.
Good catch! I wouldn't have even thought to check that.
Wish we had a more general way to test that the configs are persisted correctly.
There was a problem hiding this comment.
I don't know if it's general, but as I commented on the ticket if you check the datatype of what the butler gives you back then I think that would do it in two lines. A basic round-trip test.
There was a problem hiding this comment.
The butler already does that: my test in jointcal uses that and more.
parejkoj
force-pushed
the
tickets/DM-13757
branch
from
b29fbb2
to
bcfd5e3
Compare
erykoff
approved these changes
Mar 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.