Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-18739: add code to standardize defects #143

Merged
merged 14 commits into from
Jun 21, 2019
Merged

DM-18739: add code to standardize defects #143

merged 14 commits into from
Jun 21, 2019

Commits on Jun 14, 2019

  1. Read defect files in standard format 

    Standard format is x0, y0, x_extent, y_extent.
    @SimonKrughoff
    SimonKrughoff committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    d127c99 View commit details
    Browse the repository at this point in the history

  2. Pass through Defect instead of Box2I

    @SimonKrughoff
    SimonKrughoff committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    8e237f2 View commit details
    Browse the repository at this point in the history

  3. Remove code and clean up linting errors 

    Code was moved from here to the Defects factory method as part of DM-19373.
    @SimonKrughoff
    SimonKrughoff committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    7fab87c View commit details
    Browse the repository at this point in the history

  4. Add metadata to defects

    @SimonKrughoff
    SimonKrughoff committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    5492037 View commit details
    Browse the repository at this point in the history

  5. Remove specializations for defets

    @SimonKrughoff
    SimonKrughoff committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    0716951 View commit details
    Browse the repository at this point in the history

  6. Add parts of calib_id as proper metadata as well

    @SimonKrughoff
    SimonKrughoff committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    bbd2bc9 View commit details
    Browse the repository at this point in the history

  7. Add try block to the sanitize method for calibs 

    It turns out that not all calibration types will be Image-y.
For example, defects should not have the sanitization method applied.
This commit adds a try block and passes if sanitization fails with a
TypeError.
    @SimonKrughoff
    SimonKrughoff committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    3d789e4 View commit details
    Browse the repository at this point in the history

  8. Add explicit test for types that should be standardized

    @SimonKrughoff
    SimonKrughoff committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    fca5f23 View commit details
    Browse the repository at this point in the history

  9. Check that file metadata agrees with path

    @SimonKrughoff
    SimonKrughoff committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    511d008 View commit details
    Browse the repository at this point in the history

  10. Remove more defects related code.

    @SimonKrughoff
    SimonKrughoff committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    9603772 View commit details
    Browse the repository at this point in the history

  11. Make sure to only traverse directories 

    Defects live in directories, so make sure the reference
is a directory before attempting to traverse it.
    @SimonKrughoff
    SimonKrughoff committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    e2f1af6 View commit details
    Browse the repository at this point in the history

  12. Add docstrings and clarify handling of path names

    @SimonKrughoff
    SimonKrughoff committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    f63ad01 View commit details
    Browse the repository at this point in the history

  13. Add test for read_defects

    @SimonKrughoff
    SimonKrughoff committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    90fdda5 View commit details
    Browse the repository at this point in the history

  14. Move defects reading code to pipe_tasks from obs_base

    @SimonKrughoff
    SimonKrughoff committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    47871be View commit details
    Browse the repository at this point in the history