Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-20073: Move ObservationInfo to VisitInfo code to separate method #155

Merged
merged 4 commits into from Jun 13, 2019
Merged

DM-20073: Move ObservationInfo to VisitInfo code to separate method #155

merged 4 commits into from Jun 13, 2019

Conversation

timj
Copy link
Member

@timj timj commented Jun 12, 2019

No description provided.

timj added 2 commits June 12, 2019 11:29
@timj
Fix some warnings triggered by tests
d717351
@timj
Hide warnings from StubTranslator
ea00832 
The warnings are expected and should not appear in the pytest
warning log.
isullivan
isullivan approved these changes Jun 12, 2019
View reviewed changes
Copy link
Contributor

@isullivan isullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine, and it works for my test.

@timj
Factor out ObservationInfo to VisitInfo conversion code
2eadf17 
Put it in a static method so that it can be used
generically.
@timj timj merged commit 6c1e41c into master Jun 13, 2019
@timj timj deleted the tickets/DM-20073 branch June 13, 2019 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isullivan isullivan isullivan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@timj @isullivan