Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tickets/DM-20069 Add datasets for PTC task #159

Merged
merged 1 commit into from Oct 1, 2019
Merged

tickets/DM-20069 Add datasets for PTC task #159

merged 1 commit into from Oct 1, 2019

Conversation

mfisherlevine
Copy link
Contributor

No description provided.

mfisherlevine
mfisherlevine commented Aug 28, 2019
View reviewed changes
Copy link
Contributor Author

@mfisherlevine mfisherlevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget the point I made on Slack about the disagreement in naming between MeasurePhotonTransferCurveConfig vs MeasurePhotonTransferCurveTaskConfig. Run the task twice with the same command line args to check if you fixed this.

@mfisherlevine
Copy link
Contributor Author

Also note that you'll need a rebase before merging.

@plazas plazas force-pushed the tickets/DM-20069 branch 2 times, most recently from cc4e95f to 42047f5 Compare September 21, 2019 19:06
@mfisherlevine @plazas
Add datasets for PTC task
8274a4a 
Fix typo in datasets.yaml

Added another template for PTC output data

Renamed gain and noise output data product
@plazas plazas merged commit 8274a4a into master Oct 1, 2019
@timj timj deleted the tickets/DM-20069 branch August 17, 2020 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czwa czwa czwa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mfisherlevine @czwa @plazas