DM-22191: isr for yaml cameras is broken due to zero value for suspectLevel #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erykoff
approved these changes
Nov 12, 2019
python/lsst/obs/base/yamlCamera.py
Outdated
| if 'suspect' in amp: | ||
| amplifier.setSuspectLevel(amp['suspect']) | ||
| else: | ||
| amplifier.setSuspectLevel(float('nan')) |
There was a problem hiding this comment.
This is a stylistic thing... I personally prefer np.nan to float('nan'), but both are used in the codebase. It seems that np.nan is slightly more prevalent if that matters.
There was a problem hiding this comment.
And this could be a bit more compact. If amp is a regular dict or dict-like thing, you can do amplifier.setSuspectLevel(amp.get('suspect', np.nan)). Though maybe this is unnecessarily fancy.
There was a problem hiding this comment.
I never remember the short versions of things in python until my third or fourth look. Short form adopted.
czwa
force-pushed
the
tickets/DM-22191
branch
from
673fae9
to
44f6c55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set amplifier suspect level to NaN if not defined.