Update dataset definitions for the measurePhotonTransferCurveTask #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plazas
approved these changes
Dec 6, 2019
plazas
reviewed
Dec 9, 2019
| tables: 'raw' | ||
| template: '' | ||
| measurePhotonTransferCurveDatasetAll: | ||
| photonTransferCurveDataset: | ||
| description: "Persisted output data from the MeasurePhotonTransferCurveTask" | ||
| persistable: ignored |
There was a problem hiding this comment.
What does this "persistable" option mean and why is it set to "ignored"? The description says that you are persisting data.
There was a problem hiding this comment.
See OOB communication "explaining" this (in the loosest possible sense of "explain").
plazas
reviewed
Dec 9, 2019
| persistable: ignored | ||
| python: lsst.cp.pipe.ptc.PtcDataset | ||
| storage: PickleStorage | ||
| tables: 'raw' |
There was a problem hiding this comment.
I noticed that you left out "tables: raw" in the new definition. However, Robert had to add this again to fix a runtime error (see DM-22227).
There was a problem hiding this comment.
This is a good point, I'll check this out.
There was a problem hiding this comment.
Excellent catch, this totally needed fixing to not revert those changes, thank you!
mfisherlevine
force-pushed
the
tickets/DM-22405
branch
from
a4a87bc
to
b7e4101
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.