Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-23062: Preserve input headers #196

Merged
merged 1 commit into from Jan 15, 2020
Merged

DM-23062: Preserve input headers #196

merged 1 commit into from Jan 15, 2020

Conversation

PaulPrice
Copy link
Contributor

No description provided.

@PaulPrice PaulPrice requested a review from timj January 14, 2020 19:08
timj
timj approved these changes Jan 14, 2020
View reviewed changes
Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think to avoid weirdness with non-ObservationInfo instruments we also have to patch makeRawVisitInfo.py so that popItem doesn't do that del.

@PaulPrice
makeRawVisitInfo: don't strip header by default
a46478c 
RFC-576 established that we would propagate all input headers to the
output files, but we have been stripping header keywords used in the
creation of the VisitInfo. Made this feature optional (through a
parameter provided to the Ctor), and turned it off by default, so that
we won't lose the header keywords.

The same is done for makeRawVisitInfoViaObsInfo.
@PaulPrice PaulPrice merged commit a46478c into master Jan 15, 2020
@timj timj deleted the tickets/DM-23062 branch June 25, 2020 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timj timj timj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@PaulPrice @timj