DM-23129: Update gen3 ingest to allow for multiple datasets per file #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
approved these changes
Jan 21, 2020
parejkoj
reviewed
Jan 22, 2020
parejkoj
reviewed
Jan 22, 2020
RawFileData now takes a list of RawFileDatasetInfo which contains the dataId, region, and obsInfo for each dataset within the file. This fundamentally assumes that a single file can only contain observations from a single visit.
We are expecting people to subclass extractMetadata so should make it easier by moving out the region calculation to separate method.
I think extractMetadata is small enough to replace in a subclass. This whole design assumes that every dataset in a file shares formatter.
Strings do not need a + to concatenate them.
Consistent with RFC-650
timj
force-pushed
the
tickets/DM-23129
branch
from
c4577b8
to
9bdca29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RawFileData now takes a list of RawFileDatasetInfo which
contains the dataId, region, and obsInfo for each dataset
within the file.
This fundamentally assumes that a single file can only contain
observations from a single visit.