DM-22655: Genericize gen2to3.py to be useable with any gen2 repo #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
force-pushed
the
tickets/DM-22655
branch
4 times, most recently
from
25118e6
to
55b5e80
Compare
timj
reviewed
Mar 2, 2020
| # along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
|
|
||
| """Convert a gen2 butler repo to gen 3. See | ||
| `lsst.obs.base.ConvertRepoConfig` for most of the config options. |
There was a problem hiding this comment.
Quick note. Please use the new scheme for writing scripts when you create new ones. We now have minimalist scripts in bin.src and place the argument parsing and main in the module itself. Please see https://community.lsst.org/t/new-tools-for-documenting-ad-hoc-scripts-in-the-lsst-science-pipelines/3784
parejkoj
force-pushed
the
tickets/DM-22655
branch
from
2d9efd8
to
809c479
Compare
timj
reviewed
Mar 5, 2020
parejkoj
force-pushed
the
tickets/DM-22655
branch
from
b3e9824
to
b4c1804
Compare
This script is based of one built by Jim Bosch for ci_hsc. Add bin/ to .gitignore
Better error messages on failed skymaps. Pull out skymap dict population so we can reuse it.
DECam raw and Community Pipeline calibs are stored in multi-extension FITS files, which we handle by stripping 'ccdnum' from the gen2 template and then scanning the file for what HDUs it contains. * Strip off `[HDU]` from filenames * Change Builders, Handlers, and expandDataIds to support multi-HDU FITS. * In expandDataIds, strip the items we can't get the full dataId for (e.g. not in the gen2 calibRegistry) and prevent repeating FileDatasets.
In the default configuration, `isDatasetTypeIncluded` returns True for any input, but we can't do `os.listdir` on a nonexistent directory, so we also have to check that any refcats are configured to convert.
Some templates were magically expanded in the gen2 mapper: we need to support converting those here, without duplicating walker entries.
Gen2 was inconsistent in its use of filter names in calibReigstries, so we need multiple ways of managing that conversion.
htm.depth=7 is what we've settled on for all our refcats, not just ci_hsc.
parejkoj
force-pushed
the
tickets/DM-22655
branch
from
77d6768
to
f12b267
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.