Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-22794: Stop using daf_butler test configs #207

Merged
merged 2 commits into from Mar 12, 2020
Merged

DM-22794: Stop using daf_butler test configs #207

merged 2 commits into from Mar 12, 2020

Conversation

timj
Copy link
Member

@timj timj commented Mar 12, 2020

No description provided.

@timj
Use default butler configuration
392a324 
The test config should not be used since it sets some strange
entries used solely for internal daf_butler testing. The
default config is suitable for registry.
@timj
Switch the instrument test so that it uses the real test code
ce75c9f 
The test here was incomplete and did not use the code
designed to test instruments.
@timj timj requested a review from parejkoj March 12, 2020 21:44
parejkoj
parejkoj approved these changes Mar 12, 2020
View reviewed changes
Copy link
Collaborator

@parejkoj parejkoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up.

@timj timj merged commit 78ff95b into master Mar 12, 2020
@timj timj deleted the tickets/DM-22794 branch March 12, 2020 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parejkoj parejkoj parejkoj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@timj @parejkoj