Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-23729: Allow gen3 formatter to be associated with a dataset type in 2to3 #208

Merged
merged 4 commits into from Mar 17, 2020
Merged

DM-23729: Allow gen3 formatter to be associated with a dataset type in 2to3 #208

merged 4 commits into from Mar 17, 2020

Conversation

timj
Copy link
Member

@timj timj commented Mar 13, 2020

This lets obs_decam declare cpBias and cpFlat use non-standard formatters.

@timj
Allow gen3 formatter to be associated with a dataset type in 2to3
4324ba4 
This lets obs_decam declare cpBias and cpFlat use non-standard
formatters.
TallJimbo
TallJimbo approved these changes Mar 13, 2020
View reviewed changes
Copy link
Member

@TallJimbo TallJimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a thought: it might be worth creating a type annotation alias for formatter arguments, maybe even up in daf_butler. Not certainly the reduction in verbosity is worth the increase in opacity, but I thought I'd toss it out there.

@timj timj merged commit 830ab5e into master Mar 17, 2020
@timj timj deleted the tickets/DM-23729 branch March 17, 2020 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TallJimbo TallJimbo TallJimbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@timj @TallJimbo