DM-24337: Change raw formatters to use base API changes #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of separate methods for reading image components and info components, now have unified interface for any component.
parejkoj
reviewed
Apr 3, 2020
| @@ -271,46 +271,34 @@ def makeFilter(self): | |||
| """ | |||
| return lsst.afw.image.Filter(self.observationInfo.physical_filter) | |||
|
|
|||
| def readImageComponent(self, component): | |||
| """Read the image, mask, or variance component of an Exposure. | |||
| def readComponent(self, component, parameters=None): | |||
There was a problem hiding this comment.
I don't see parameters used anywhere in the method.
There was a problem hiding this comment.
Correct. The base class requires the argument though since the butler may pass parameters in. Parameters are not used by any of the raw formatter code so this is a long standing issue. I made a comment on the Jira ticket. At some point we need to decide what parameters make sense for raw formatter (maybe only bounding box) and complain if any others turn up. Currently the storage class defines the allowed parameters and that might lead to a special RawExposure storage class that defines a different set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than separate calls for different types of components we now have a generic readComponent method.