DM-24352: Add new link and auto transfer modes and default to auto for 2to3 #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
approved these changes
Apr 5, 2020
| @@ -172,7 +172,7 @@ def convert(gen2root, gen3root, instrumentClass, calibFilterType, | |||
| instrument.applyConfigOverrides(ConvertRepoTask._DefaultName, convertRepoConfig) | |||
| if convertRepoConfig.raws.instrument is None: | |||
| convertRepoConfig.raws.instrument = instrumentClass | |||
| convertRepoConfig.raws.transfer = "symlink" | |||
| convertRepoConfig.raws.transfer = "auto" | |||
There was a problem hiding this comment.
This really needs to be controllable from the command-line. The right way to do that is to leverage the pex_config-override argument parsing that's in ctrl_mpexec, so maybe that can wait until we make this a butler subcommand.
But we also shouldn't let the lack of command-line flexibility now bias our choice of default behavior (especially down in daf_butler; see PR comment there). It'd be better to add an argparse option here for transfer mode manually, even if we do later replace it with more general pex_config stuff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.