DM-24545: fix typo in register-instrument command name #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
reviewed
Apr 23, 2020
| @@ -30,7 +30,7 @@ | |||
| log = logging.getLogger(__name__) | |||
|
|
|||
|
|
|||
| @click.command("register_instrument") | |||
| @click.command() | |||
There was a problem hiding this comment.
In daf_butler I see
@click.command(name="config-validate")
and I also see the form above (no name at all). Neither of these is the form stated on the ticket as the plan so I'm more confused than when I started 😄
The subcommand name comes from the function name, with the underscore
changed to a dash.
If named, the subcommand name should have had a dash ("register-instrument"),
but it didn't matter so much because Click was changing the underscore
to a dash with the explicitly provided command name anyway. But this
is more correct.
n8pease
force-pushed
the
tickets/DM-24545
branch
from
f8cd617
to
b4e6e6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The subcommand name comes from the function name, with the underscore
changed to a dash.
If named, the subcommand name should have had a dash ("register-instrument"),
but it didn't matter so much because Click was changing the underscore
to a dash with the explicitly provided command name anyway. But this
is more correct.