DM-24559 (pass butler registry to getInstrument) and DM-24683 (use PRODUCT_DIR instead of OBS_BASE_DIR) #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8pease
force-pushed
the
tickets/DM-24559
branch
from
8e1fdfe
to
e9d1590
Compare
ktlim
changed the title
TallJimbo
approved these changes
Apr 30, 2020
| """ | ||
|
|
||
| instrument_name = None | ||
| """The instrument name.""" |
There was a problem hiding this comment.
It's not so bad as long as it's just these two, but if the number of must-be-provided attributes grows much more, abstract method getters would be much safer (IMO ingest_tests has definitely passed that point), and I would not object at all to switching up to that approach up front.
| """ | ||
|
|
||
| instrument_class = None | ||
| """The fully qualified instrument class. |
There was a problem hiding this comment.
I assume this is class name, not the the type object?
n8pease
force-pushed
the
tickets/DM-24559
branch
from
e9d1590
to
c2b1168
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DM-24683: Use PRODUCT_DIR instead of OBS_BASE_DIR in obs_base eups table file
DM-24559: write_curated_calibrations is not passing the butler registry to getInstrument