DM-24920: improve butler CLI mocking #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
approved these changes
May 13, 2020
|
|
||
| def test_repoAndOutput(self): | ||
| """Test the most basic required arguments, repo and output run""" | ||
| expected = makeExpectedKwargs(repo="here", output_run="out") | ||
| self.run_test(["ingest-raws", "here", "--output-run", "out"], expected) | ||
| self.run_test(["ingest-raws", "here", |
There was a problem hiding this comment.
it's not necessary, but makes this test function look like the rest of the test functions in the suite, making it so that in the tuple of parameters each option+value is on a separate line (the first line is consistently a special case, subcommand+repo), which IMO is easier to read.
tests/test_cliCmdTestIngest.py
Outdated
| @@ -43,6 +44,9 @@ def makeExpectedKwargs(**kwargs): | |||
|
|
|||
| class Suite(unittest.TestCase): | |||
|
|
|||
| def setUp(self): | |||
| sys.modules["lsst.obs.base.script.ingestRaws"] = lsst.obs.base.cli.test.ingestRaws | |||
There was a problem hiding this comment.
I'd feel better if there was a teardown that reversed this since sys.modules is a global.
There was a problem hiding this comment.
good point. I've used unittest.patch for this recently, I'll look into using it for this situation.
n8pease
force-pushed
the
tickets/DM-24920
branch
2 times, most recently
from
9cb80c9
to
f260fc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.