DM-24923: eliminate redundant class name & name requirement in butler command test cases #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
approved these changes
May 15, 2020
There was a problem hiding this comment.
One minor naming quibble. I would like you to split this into two commits though. As well as the change that you describe in the commit, you have also gone through and changed the case of rawIngestTask property. That's completely unrelated to the instrument class refactor so should be on a separate commit.
python/lsst/obs/base/ingest_tests.py
Outdated
| pass | ||
|
|
||
| @property | ||
| def instrument(self): |
There was a problem hiding this comment.
I think for clarity this should be instrumentClass.
| def instrumentName(): | ||
| """Get the instrument name. | ||
| @property | ||
| def instrument(self): |
There was a problem hiding this comment.
instrument implies an instance of Instrument so I think instrumentClass would add clarity.
Class instance and instrument name can all be obtained from the class name. Use abstract property to ensure that the class name is provided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Class instance and instrument name can all be obtained from the
class name.
Use abstract property to ensure that the class name is provided.