Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-25152: Pre-import all known instruments before running ingest #254

Merged
merged 4 commits into from
May 29, 2020
Merged

DM-25152: Pre-import all known instruments before running ingest #254

merged 4 commits into from
May 29, 2020

Commits on May 29, 2020

  1. Change Instrument.getName to staticmethod 

    We weren't using the cls argument at all so remove it.
    @timj
    timj committed May 29, 2020
    Configuration menu
    Copy the full SHA
    884d4e8 View commit details
    Browse the repository at this point in the history

  2. Add Instrument.importAll method 

    This can be used to force all known instrument classes to
be imported.
    @timj
    timj committed May 29, 2020
    Configuration menu
    Copy the full SHA
    ee981dd View commit details
    Browse the repository at this point in the history

  3. Force ingest task to pre-import all Instrument classes 

    This allows all the relevant metadata translators to
be pulled in.
    @timj
    timj committed May 29, 2020
    Configuration menu
    Copy the full SHA
    6641c04 View commit details
    Browse the repository at this point in the history

  4. Remove unused parameters from Instrument constructor 

    We rely on Instrument being instantiated without any parameters
in many places so including them in the base class is confusing.
    @timj
    timj committed May 29, 2020
    Configuration menu
    Copy the full SHA
    57cb5cf View commit details
    Browse the repository at this point in the history