obs_base Tickets/dm 7468 #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8pease
force-pushed
the
tickets/DM-7468
branch
from
e4e50d6
to
d2ac848
Compare
andy-slac
approved these changes
Mar 22, 2017
python/lsst/obs/base/cameraMapper.py
Outdated
| @@ -789,10 +792,14 @@ def _setupRegistry(self, name, path, policy, policyKey, storage, searchParents=T | |||
| if newPath is not None: | |||
| path = newPath | |||
| self.log.debug("Loading %s registry from %s", name, path) | |||
| registry = dafPersist.Registry.create(storage.getLocalFile(path)) | |||
| localFileObj = storage.getLocalFile(path) | |||
| registry = dafPersist.Registry.create(localFileObj.name) | |||
There was a problem hiding this comment.
I presume it's OK that localFileObj can go out of scope and delete temporary file associated with it?
n8pease
force-pushed
the
tickets/DM-7468
branch
2 times, most recently
from
c5275d1
to
584a741
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.