DM-25327: Add new PackagesFormatter #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
approved these changes
Jun 12, 2020
timj
force-pushed
the
tickets/DM-25327
branch
2 times, most recently
from
83930f1
to
6c2d587
Compare
This formatter has a configurable write parameter to control yaml vs pickle format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This formatter is a specialist formatter for
lsst.base.Packagesand control of the file format for writing is handled by a writeParameter in the configuration. This is acting as a demonstrator that such a scheme will work and required some changes to Formatter base class to allowFormatter.extensionto be an instance property rather than a class property.Currently this formatter does not stream to/from bytes because Packages can't do that yet (it would be easy to add).
Also updates the FitsExposureFormatter to declare that .fits.gz is understood.
Depends on lsst/daf_butler#309