Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-24319: Add support for new parquet source tables in fgcmcal #263

Merged
merged 1 commit into from Jul 3, 2020

Conversation

erykoff
Copy link
Contributor

@erykoff erykoff commented Jun 15, 2020

No description provided.

Copy link
Collaborator

@parejkoj parejkoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One yaml syntax question.

@@ -974,6 +982,14 @@ fgcmCalibrateTract_config:
storage: ConfigStorage
python: lsst.fgcmcal.fgcmCalibrateTract.FgcmCalibrateTractConfig
template: config/fgcmCalibrateTract.py
fgcmCalibrateTractTable_config:
description: >-
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the >- here and not in the other one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dunno, that's what my editor (emacs) automatically put in there. I guess it's not necessary?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's necessary: I don't see it in any of our other YAML files.

@erykoff erykoff merged commit 34741e2 into master Jul 3, 2020
@erykoff erykoff deleted the tickets/DM-24319 branch July 3, 2020 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants