DM-25458: Refactor raw/calib collection naming #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
timj
commented
Jun 19, 2020
timj
commented
- Use single location for combining instrument name with collection label.
- No longer require the user to specify the output collection for ingest-raws and write-curated-calibrations.
This stops us having to remember whether it's instrument/raw or raw/instrument.
The output_run is now optional on the command line and if not specified a suitable value will be used that is derived from the data. We now allow files from multiple instruments to be ingested at once (assuming they are compatible with the Task being used) into their own collections.
This was referenced Jun 19, 2020
Merged
TallJimbo
approved these changes
Jun 19, 2020
No longer required to specify calib/hsc on the command line.
This simplifies the subaru implementation such that that subclass does not have to recalculate the run.
We need something to give us the default raw collection name but since we can't predict all the other defaults at this time, change the default method to specifically relate to raws. As part of this we move from "construct" to "make" in the API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.