DM-25923: Cache result from yamlCamera.makeCamera #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonKrughoff
approved these changes
Jul 14, 2020
python/lsst/obs/base/yamlCamera.py
Outdated
| @@ -31,6 +32,7 @@ | |||
| __all__ = ["makeCamera"] | |||
|
|
|||
|
|
|||
| @lru_cache(maxsize=20) | |||
There was a problem hiding this comment.
Just curious why maxsize is altered from the default of 128. I guess you'll say that we won't have more than 20 cameras anyway, but if that's the argument leaving the default would seem to be OK. If we did use the default, would holding 128 cameras in memory be an issue?
There was a problem hiding this comment.
Yes, I was sort of thinking "20 is more cameras than could ever be wanted in a single process" so picked that. I can definitely remove it if it's confusing. Cameras are quite large in general but I can't really foresee a situation where we have 128 instruments in one process and that's our only concern about memory.
Constructing a camera from YAML can take a long time (10 seconds for imsim) but the resulting object is immutable. Caching can significantly speed up code that creates multiple cameras (in particular gen2 to 3 conversion code).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constructing a camera from YAML can take a long time (10 seconds for imsim) but the resulting object is immutable. Caching can significantly speed up code that creates multiple cameras (in particular gen2 to 3 conversion code).