Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-26304: Relocate pexConfig formatter to here from daf_butler and test it #289

Merged
merged 1 commit into from Aug 21, 2020
Merged

DM-26304: Relocate pexConfig formatter to here from daf_butler and test it #289

merged 1 commit into from Aug 21, 2020

Conversation

timj
Copy link
Member

@timj timj commented Aug 20, 2020

No description provided.

TallJimbo
TallJimbo approved these changes Aug 21, 2020
View reviewed changes
Copy link
Member

@TallJimbo TallJimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure everything I commented on was just moved as-is from daf_butler, but I did see some docstring formatting issues and what looks like a debugging relic.

python/lsst/obs/base/formatters/pexConfig.py Outdated Show resolved Hide resolved
python/lsst/obs/base/formatters/pexConfig.py Outdated Show resolved Hide resolved
python/lsst/obs/base/formatters/pexConfig.py Outdated Show resolved Hide resolved
python/lsst/obs/base/formatters/pexConfig.py Outdated Show resolved Hide resolved
@timj
Copy link
Member Author

timj commented Aug 21, 2020

Yes, the docstring issues were all there before. I have fixed many of them on DM-26008.

@timj timj merged commit db4d86a into master Aug 21, 2020
@timj timj deleted the tickets/DM-26304 branch August 21, 2020 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TallJimbo TallJimbo TallJimbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@timj @TallJimbo