Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-26545: Add spline linearizer. #311

Merged
merged 2 commits into from Oct 23, 2020
Merged

DM-26545: Add spline linearizer. #311

merged 2 commits into from Oct 23, 2020

Conversation

czwa
Copy link
Contributor

@czwa czwa commented Oct 8, 2020

Dataset definitions for MeasureLinearityTask.

persistable: PropertySet
storage: YamlStorage
python: lsst.daf.base.PropertySet
template: ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This while change looks fine, but the template is blank (also fine) I just don't see a PR for obs_lsst where I assume this is being run, so just checking how this works, or if Jira has failed to pick up the ticket.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing useful is being written to the metadata, so I'd ignored it. I've added an obs_lsst PR (261) to define the metadata output to prevent future issues.

python: lsst.cp.pipe.linearity.MeasureLinearityConfig
storage: ConfigStorage
tables:
- 'raw'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could be wrong, but I don't think tables is needed/makes sense here (and the other config stores I looked at don't define it).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is based (in some roundabout way) on other entries. I've removed the tables attribute, and assume this won't cause issues. I believe this is less fussy in gen3.

@czwa czwa merged commit ad89340 into master Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants