DM-24355: make visit definition and instrument registration idempotent. #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
reviewed
Oct 9, 2020
| @@ -103,6 +103,9 @@ def test_register(self): | |||
| registeredInstrument = Instrument.fromName(self.instrument.getName(), registry) | |||
| self.assertEqual(type(registeredInstrument), type(self.instrument)) | |||
|
|
|||
| # Check that re-registration is not an error. | |||
| self.instrument.register(registry) | |||
There was a problem hiding this comment.
Does this mean that the try block at https://github.com/lsst/obs_base/blob/master/python/lsst/obs/base/gen2to3/convertRepo.py#L497-L500 can be removed now?
It is now safe to attempt to define the same visit twice, as long as the definitions actually are the same.
Mostly, just document and test that it should be; it's really up to subclasses to follow through.
TallJimbo
force-pushed
the
tickets/DM-24355
branch
from
31dbf23
to
1cd0a1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.