DM-27164: Add visitSummary dataset #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenam
reviewed
Oct 15, 2020
policy/datasets.yaml
Outdated
| @@ -570,6 +570,16 @@ sourceTable_visit: | |||
| python: lsst.pipe.tasks.parquetTable.ParquetTable | |||
| tables: raw | |||
| template: '' | |||
| visitSummary: | |||
| description: > | |||
| Per-visit combination of visit metatadata, WCS, photoCalib, and | |||
parejkoj
reviewed
Oct 19, 2020
| storage: FitsCatalogStorage | ||
| python: lsst.afw.table.ExposureCatalog | ||
| tables: raw | ||
| template: '' |
There was a problem hiding this comment.
I think this is something that could have a useful default template (yeah, it's gen2, but still). Maybe summary/visitSummary-%(visit)07d.fits? I don't understand why our parquet output doesn't have default templates either. That way other cameras can use it without specialization.
There was a problem hiding this comment.
Some of this is moot with the move to Gen3. In the meantime, I'm going to follow the already established pattern.
erykoff
force-pushed
the
tickets/DM-27164
branch
2 times, most recently
from
104aa0c
to
d4f2c5f
Compare
erykoff
force-pushed
the
tickets/DM-27164
branch
from
d4f2c5f
to
67799fd
Compare
erykoff
force-pushed
the
tickets/DM-27164
branch
from
67799fd
to
900bc9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.