DM-27171: Speed up gen3 ingest tests #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
timj
commented
Oct 15, 2020
timj
commented
- Do not read complete datasets for every transfer mode.
- Share a butler between tests (so you don't need to keep registering the instrument)
timj
force-pushed
the
tickets/DM-27171
branch
from
66c68ec
to
10ebb70
Compare
parejkoj
reviewed
Oct 17, 2020
We do not need to read the same raws in every ingest check. We also do not need to read every raw dataset that was ingested. Read the first raw completely but for subsequent raws just read some metadata to demonstrate that the datastore can read them. Changing this can make significant improvements to test runtimes.
It doesn't depend on any of the loop variables.
Previously the in place code was never triggering and it was picking up the original file. Now explicitly override the file being ingested and check that the URI matches our expectations.
timj
force-pushed
the
tickets/DM-27171
branch
from
10ebb70
to
e3aeda9
Compare
Register instrument takes a while for some instruments and it always does the same thing and can be reused for each test.
timj
force-pushed
the
tickets/DM-27171
branch
from
e3aeda9
to
62d0741
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.