DM-28109: Test failure in obs_base test_cameraMapper.Mapper2TestCase #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktlim
reviewed
Dec 18, 2020
| @@ -218,6 +218,12 @@ def testNames(self): | |||
| class Mapper2TestCase(unittest.TestCase): | |||
| """A test case for the mapper used by the data butler.""" | |||
|
|
|||
| def setUp(self): | |||
| super().setUp() | |||
There was a problem hiding this comment.
Is this ever necessary for a direct inheritor from unittest.TestCase?
There was a problem hiding this comment.
Maybe not, but it's good practice in general, and does no harm here.
ktlim
approved these changes
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where one of the test cases depended on
Filterwith specific filters, but, depending on test execution order, those filters were not guaranteed to have been registered.