Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-28236: get('calexp_filterLabel') does not return a full label for pre-FilterLabel data #341

Merged
merged 4 commits into from
Jan 13, 2021
Merged

DM-28236: get('calexp_filterLabel') does not return a full label for pre-FilterLabel data #341

merged 4 commits into from
Jan 13, 2021

Commits on Jan 12, 2021

  1. Factor filter selection from CameraMapper._setFilter. 

    This factoring makes it possible to use the same logic in contexts
other than Exposure.
    @kfindeisen
    kfindeisen committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    5320fc3 View commit details
    Browse the repository at this point in the history

  2. Add real exposure to MinMapper2 tests. 

    This dataset allows for testing of exposure components.
    @kfindeisen
    kfindeisen committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    6e13d9a View commit details
    Browse the repository at this point in the history

  3. Switch CameraMapper standardizeFilter tests to i-band. 

    Switching to i-band makes the "r" filter used in test data unambiguous,
which simplifies tests that use those files.
    @kfindeisen
    kfindeisen committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    bb728a8 View commit details
    Browse the repository at this point in the history

  4. Refine filters loaded from exposures using '_filterLabel'. 

    The same post-processing is now applied to filters loaded directly and
as part of an Exposure, providing a consistent result no matter how
the filter is read.
    @kfindeisen
    kfindeisen committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    12c8080 View commit details
    Browse the repository at this point in the history