DM-29313: FilterLabel is not properly filled in for CFHT raws #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_standardizeExposure sets the WCS only if it is not yet set, and prefers boresight-based WCS to metadata-based. Therefore, exposureFromImage should not set the WCS from the metadata.
parejkoj
approved these changes
Mar 30, 2021
Code will now recognize that filters identified by an afw_name are unlikely to be referred to by any other name.
kfindeisen
force-pushed
the
tickets/DM-29313
branch
from
23c3a95
to
d2fb979
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies two fixes to filter ambiguity problems reported in Gen 2. The first preserves information read from non-
Exposureimage files, the second adds a rule to disambiguate a common case of multiple filters matching a single band.