DM-28636: various improvements to help with shared repo setup #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to register the CALIBRATION collection before trying to certify into it.
This makes it a bit more possible for us to catch problems before we start writing to the Gen3 repo.
timj
approved these changes
Apr 5, 2021
| @@ -119,16 +120,19 @@ def runRawIngest(self, pool=None): | |||
| dataRefs = self.butler2.subset(self.task.config.rawDatasetType) | |||
| dataPaths = getDataPaths(dataRefs) | |||
| self.task.log.info("Ingesting raws from root %s into run %s.", self.root, self.task.raws.butler.run) | |||
| self._rawRefs.extend(self.task.raws.run(dataPaths, pool=pool)) | |||
| if not self.task.dry_run: | |||
| self._rawRefs.extend(self.task.raws.run(dataPaths, pool=pool)) | |||
There was a problem hiding this comment.
I think I'd expect dry run to issue a log message saying something like "Skipping raw ingest for {dataPaths}".
| return | ||
| dimensions = DimensionGraph(self.task.universe, names=["exposure"]) | ||
| exposureDataIds = set(ref.dataId.subset(dimensions) for ref in self._rawRefs) | ||
| self.task.log.info("Defining visits from exposures.") | ||
| self.task.defineVisits.run(exposureDataIds, pool=pool) | ||
| if not self.task.dry_run: | ||
| self.task.defineVisits.run(exposureDataIds, pool=pool) |
There was a problem hiding this comment.
As above may a log message saying that N exposureDataIds would have had visits defined?
TallJimbo
force-pushed
the
tickets/DM-28636
branch
from
73afd3f
to
7a54d1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many other improvements have already been spun off into their own tickets. What remains here are miscellaneous small things that didn't seem to meet that threshold.