Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dataset type for spectractor output #383

Merged
merged 1 commit into from Jun 23, 2021
Merged

Add dataset type for spectractor output #383

merged 1 commit into from Jun 23, 2021

Conversation

mfisherlevine
Copy link
Contributor

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

czwa
czwa approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@czwa czwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as the file is unique, this looks fine.

policy/datasets.yaml Outdated
persistable: ignored
python: None
storage: PickleStorage
template: 'spectractorOutput/%(dayObs)s/%(seqNum)04d/spectraction.pickle'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This filename isn't unique (although the directory is), which may confuse things outside of a butler context.

@mfisherlevine mfisherlevine merged commit 0d25705 into master Jun 23, 2021
@mfisherlevine mfisherlevine deleted the tickets/DM-26719 branch June 23, 2021 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czwa czwa czwa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mfisherlevine @czwa