DM-31060: Clean up some log message usage #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsst.log supports both but logging prefers warning.
The latter is not supported by python logging
parejkoj
approved these changes
Jul 16, 2021
| @@ -1213,7 +1213,7 @@ def _standardizeExposure(self, mapping, item, dataId, filter=True, | |||
| exposure = exposureFromImage(item, dataId, mapper=self, logger=self.log, | |||
| setVisitInfo=setVisitInfo, setFilter=filter) | |||
| except Exception as e: | |||
| self.log.error("Could not turn item=%r into an exposure: %s" % (repr(item), e)) | |||
| self.log.error("Could not turn item=%r into an exposure: %s", item, e) | |||
There was a problem hiding this comment.
That repr is probably there because we don't have good str for many objects, but that's something we should just fix when it comes up.
There was a problem hiding this comment.
Yes. I was a bit confused why we were calling repr twice: once with repr and once with %r...
There was a problem hiding this comment.
Oh, ha! I didn't even notice that. Good catch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes