DM-31903, hotfix: add default to new registerInstrument script command option. #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This restores backwards compatibility with the signature prior to DM-31903, though downstream code really should not be using these script functions (ci_builder does, and that led to DM-31903 breaking ci_imsim; I've created DM-31915 to address that, as it's not something I want to hotfix).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores backwards compatibility with the signature prior to DM-31903, though downstream code really should not be using these script functions (ci_builder does, and that led to DM-31903 breaking ci_imsim; I've created DM-31915 to address that, as it's not something I want to hotfix).
Checklist
doc/changes