Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-35670: Add missing lsst.afw.cameraGeom.testUtils for assertDetectorsEqual. #428

Merged
merged 1 commit into from Aug 10, 2022
Merged

DM-35670: Add missing lsst.afw.cameraGeom.testUtils for assertDetectorsEqual. #428

merged 1 commit into from Aug 10, 2022

Conversation

erykoff
Copy link
Contributor

@erykoff erykoff commented Aug 9, 2022

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@erykoff erykoff requested a review from timj August 9, 2022 16:03
timj
timj approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Maybe add a comment to the end to tell confused people why (it's funny that flake8 does not complain -- it assumes that the line above will import it).

import lsst.afw.cameraGeom.testUtils  # For assertDetectorsEqual

@erykoff erykoff merged commit 9e4e920 into main Aug 10, 2022
@erykoff erykoff deleted the tickets/DM-35670 branch August 10, 2022 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timj timj timj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@erykoff @timj