DM-13711: Add type of observation information to visitInfo #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
force-pushed
the
tickets/DM-13711
branch
2 times, most recently
from
7cc8cc9
to
be1ff98
Compare
timj
reviewed
Sep 1, 2022
There was a problem hiding this comment.
This looks fine but can you please add tests for this in test_makeRawVisitInfoViaObsInfo.py? The infrastructure is all set up for it and you did express concern that this was not tested.
Adding _const_map section to the NewTranslator class will demonstrate that the content does appear as expected in a VisitInfo. To test the case where the new values are all None you would either have to make a completely new translator class with different hard-coded values, or else drop _const_map and add explicit translations for each attribute -- then you can control the output based on the test header you pass in.
parejkoj
force-pushed
the
tickets/DM-13711
branch
from
be1ff98
to
c83f52f
Compare
|
I've added tests of the new fields, including empty value handling. |
parejkoj
force-pushed
the
tickets/DM-13711
branch
from
c83f52f
to
db691cb
Compare
parejkoj
force-pushed
the
tickets/DM-13711
branch
from
db691cb
to
ac4a970
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.