Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-27811: Remove deprecated filterLabel component. #434

Merged
merged 1 commit into from Oct 6, 2022
Merged

DM-27811: Remove deprecated filterLabel component. #434

merged 1 commit into from Oct 6, 2022

Conversation

erykoff
Copy link
Contributor

@erykoff erykoff commented Oct 5, 2022

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@erykoff erykoff force-pushed the tickets/DM-27811 branch 2 times, most recently from c8cb969 to 4877849 Compare October 5, 2022 20:47
kfindeisen
kfindeisen requested changes Oct 5, 2022
View reviewed changes
Copy link
Member

@kfindeisen kfindeisen left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, you missed exposureAssembler.py, which needs to be kept in sync with the non-disassembled code. The way the tests are set up means that removing filterLabel from test_butlerFits prevents the mismatch from being covered in tests. 😞

doc/changes/DM-27811.removal.md
@@ -0,0 +1 @@
Remove deprecated filterLabel exposure component access.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would argue for merging these two commits, as they're not self-contained -- if 2e0ca30 were removed, this log would be incorrect; if 4877849 were removed, the cleanup would be incomplete.

@erykoff
Copy link
Contributor Author

erykoff commented Oct 6, 2022

Thanks for catching that! I was relying too much on todos and not enough on grep. Anyway, everything is removed now.

kfindeisen
kfindeisen approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@kfindeisen kfindeisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@erykoff erykoff merged commit 9c3a550 into main Oct 6, 2022
@erykoff erykoff deleted the tickets/DM-27811 branch October 6, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfindeisen kfindeisen kfindeisen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@erykoff @kfindeisen