Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-31924: implement new data ID packer and deprecate ExposureIdInfo #450

Merged
merged 1 commit into from
Apr 27, 2023
Merged

DM-31924: implement new data ID packer and deprecate ExposureIdInfo #450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/changes/DM-31924.removal.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Deprecate `ExposureIdInfo` in favor of `lsst.meas.base.IdGenerator`.
6 changes: 6 additions & 0 deletions python/lsst/obs/base/exposureIdInfo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,16 @@

from typing import Optional

from deprecated.sphinx import deprecated
from lsst.afw.table import IdFactory
from lsst.daf.butler import DataCoordinate


@deprecated(
"Deprecated in favor of lsst.meas.base.CatalogIdPacker; will be removed after v27.",
version="v26",
category=FutureWarning,
)
class ExposureIdInfo:
"""Struct representing an exposure ID and the number of bits it uses.

Expand Down
3 changes: 0 additions & 3 deletions python/lsst/obs/base/ingest_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,9 +479,6 @@ def testDefineVisits(self):
for dataId in detectorVisitDataIds:
self.assertTrue(foundVisit.region.contains(dataId.region))

idInfo = lsst.obs.base.ExposureIdInfo.fromDataId(dataId)
self.assertGreater(idInfo.unusedBits, 0)

# Check obscore table again.
self._check_obscore(butler.registry, has_visits=True)

Expand Down
45 changes: 0 additions & 45 deletions tests/test_exposureIdInfo.py
View file
Open in desktop

This file was deleted.