DM-42012: Enable reading sub-regions and components for MaskedImage #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunkannawadi
force-pushed
the
tickets/DM-42012
branch
2 times, most recently
from
27c76ba
to
60535c1
Compare
timj
approved these changes
Dec 6, 2023
| # Put the MaskedImage into the Butler and get a reference to it. | ||
| dataId = {"visit": 42, "instrument": "DummyCam", "physical_filter": "d-r"} | ||
| ref = self.butler.put(mi, "noise", dataId) | ||
| handle = self.butler.getDeferred(ref) |
There was a problem hiding this comment.
Can you also do a butler.get(ref) to make sure you really do get the original masked image back?
There was a problem hiding this comment.
Added a test. I had initially avoided it thinking it checks a more generic butler capability and had nothing specific to do with MaskedImage.
|
PS Typo in commit message: "prembles" |
arunkannawadi
force-pushed
the
tickets/DM-42012
branch
from
60535c1
to
e9dafab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes