obs_base - add tests for composite bypass and std #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8pease
force-pushed
the
tickets/DM-11251
branch
2 times, most recently
from
669ccb8
to
8db1ed9
Compare
kennywlo
reviewed
Jul 12, 2017
| def std_stdTestType(self, item, dataId): | ||
| item.standardized = True | ||
| return item | ||
|
|
There was a problem hiding this comment.
Does it have to be set inside a class method?
andy-slac
approved these changes
Jul 12, 2017
| @@ -40,3 +40,10 @@ def _makeCamera(self, policy, repositoryDir): | |||
| """Normally this makes a camera. For composite testing, we don't need a camera. | |||
| """ | |||
| return None | |||
|
|
|||
| def std_stdTestType(self, item, dataId): | |||
There was a problem hiding this comment.
LDM-463 says method should look like std_<datasetType>(self, item) and this has one extra argument
There was a problem hiding this comment.
thanks. I fixed the document.
n8pease
force-pushed
the
tickets/DM-11251
branch
from
8db1ed9
to
b084507
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.