DM-11326: CameraMapper: add <exposure>_dims dataset #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenam
reviewed
Jul 20, 2017
python/lsst/obs/base/cameraMapper.py
Outdated
| md = afwImage.readMetadata(location.getLocationsWithRoot()[0]) | ||
| return afwGeom.Extent2I(md.get("NAXIS1"), md.get("NAXIS2")) | ||
| setMethods("dims", bypassImpl=dimsBypass) | ||
|
|
There was a problem hiding this comment.
Can you move the setMethods call outside of the if...elif block?
There was a problem hiding this comment.
No, they're different.
|
Instead of |
|
Good idea. New implementation to come soon.... |
PaulPrice
force-pushed
the
tickets/DM-11326
branch
from
fb85468
to
2b033f3
Compare
parejkoj
approved these changes
Jul 24, 2017
python/lsst/obs/base/cameraMapper.py
Outdated
| @@ -423,6 +423,15 @@ def setMethods(suffix, mapImpl=None, bypassImpl=None, queryImpl=None): | |||
| bypassImpl=lambda datasetType, pythonType, location, dataId: | |||
| afwImage.Filter( | |||
| afwImage.readMetadata(location.getLocationsWithRoot()[0]))) | |||
| setMethods("bbox", bypassImpl=lambda dsType, pyType, location, dataId: | |||
There was a problem hiding this comment.
All of the examples above use datasetType and pythonType: that's better than an unnecessary abbreviation. And the same below.
PaulPrice
force-pushed
the
tickets/DM-11326
branch
from
2b033f3
to
5cf4777
Compare
|
Fixed the variable names. Yes, this should allow you to do |
This allows the user to retrieve the bounding box of an image without retrieving the image itself, or assuming it's FITS under the covers.
PaulPrice
force-pushed
the
tickets/DM-11326
branch
from
5cf4777
to
aa8612d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the user to retrieve the size of an image without
retrieving the image itself, or assuming it's FITS under the
covers.