DM-9153: Add <exposure>_detector dataset #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
approved these changes
Jul 24, 2017
| mapper = MinMapper2(root=testDir) | ||
| butler = dafPersist.ButlerFactory(mapper=mapper).create() | ||
| detector = butler.get("raw_detector", ccd=0) | ||
| self.assertEqual(detector.getName(), "ccd00") |
There was a problem hiding this comment.
Nice: I see that there wasn't a test on the detector name before.
python/lsst/obs/base/cameraMapper.py
Outdated
| mapper=self, | ||
| storage=None,#self.rootStorage | ||
| ), | ||
| bypassImpl=lambda dsType, pyType, location, dataId: |
There was a problem hiding this comment.
datasetType and pythonType please.
python/lsst/obs/base/cameraMapper.py
Outdated
| locationList="ignored", | ||
| dataId=dataId, | ||
| mapper=self, | ||
| storage=None,#self.rootStorage |
There was a problem hiding this comment.
Why the commented self.rootStorage here?
PaulPrice
force-pushed
the
tickets/DM-9153
branch
from
9dfcbd9
to
36725bc
Compare
Pulls the detector from the camera object stored in the CameraMapper.
PaulPrice
force-pushed
the
tickets/DM-9153
branch
from
36725bc
to
6e92575
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls the detector from the camera object stored in the CameraMapper.