DM-11771: Close files that have been left hanging #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
commented
Sep 1, 2017
tests/testCameraMapper.py
Outdated
| @@ -413,16 +439,19 @@ def test(self): | |||
| registryA = butler._repos.inputs()[0].repo._mapper.registry | |||
| registryB = butler._repos.outputs()[0].repo._mapper.registry | |||
| self.assertEqual(id(registryA), id(registryB)) | |||
| del registryA | |||
| del registryB | |||
There was a problem hiding this comment.
I am guessing that these three del calls are not needed because the assignment later will overwrite them.
tests/testCameraMapper.py
Outdated
|
|
||
| del registryA | ||
| del registryB | ||
| del butler |
There was a problem hiding this comment.
Do these make a difference now? The variables will disappear at end of scope and the gc.collect() will clean up.
| with open(os.path.join(self.repoARoot, 'registry.sqlite3'), 'w') as f: | ||
| f.write('123') | ||
| self._createRegistry(os.path.join(self.repoARoot, 'registry.sqlite3')) | ||
| del butler |
There was a problem hiding this comment.
This might be needed, but keeping it means that the linter won't complain about butler only being used once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.